Saggi Mizrahi has posted comments on this change.
Change subject: Refactor storage connection subsystem
......................................................................
Patch Set 11: (3 inline comments)
....................................................
File vdsm/storage/hsm.py
Line 1865: conInfo = _connectionDict2ConnectionInfo(conDef)
You are right. My bad.
Line 1913: conInfo = _connectionDict2ConnectionInfo(conDef)
You are right once again!
Line 1931: def _translateConnectionError(self, e):
I actually forgot I wrote that. I should use this
--
To view, visit
http://gerrit.ovirt.org/1038
To unsubscribe, visit
http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ifc5c160aba9b4cc88225dde0c44f9b766c6a4c0d
Gerrit-PatchSet: 11
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Saggi Mizrahi <smizrahi(a)redhat.com>
Gerrit-Reviewer: Ayal Baron <abaron(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Ewoud Kohl van Wijngaarden <ewoud(a)kohlvanwijngaarden.nl>
Gerrit-Reviewer: Federico Simoncelli <fsimonce(a)redhat.com>
Gerrit-Reviewer: Igor Lvovsky <ilvovsky(a)redhat.com>
Gerrit-Reviewer: Saggi Mizrahi <smizrahi(a)redhat.com>