Francesco Romani has posted comments on this change.
Change subject: vm: per-attribute monitor response check
......................................................................
Patch Set 6: -Verified
(2 comments)
http://gerrit.ovirt.org/#/c/23138/6/vdsm/vm.py
File vdsm/vm.py:
Line 3668: wasEmpty = len(self._attributeTimeouts) == 0
Line 3669: self._attributeTimeouts.add(attrName)
Line 3670: if wasEmpty:
Line 3671: self.log.warning('monitor unresponsive'
Line 3672: ' for attribute timeout')
Maybe add the failing attribute name to the message?
Good idea,
let me try some alternatives.
Line 3673: elif attrName in self._attributeTimeouts:
Line 3674: self._attributeTimeouts.remove(attrName)
Line 3675: if len(self._attributeTimeouts):
Line 3676: self.log.warning('monitor responsive again')
Line 3671: self.log.warning('monitor unresponsive'
Line 3672: ' for attribute timeout')
Line 3673: elif attrName in self._attributeTimeouts:
Line 3674: self._attributeTimeouts.remove(attrName)
Line 3675: if len(self._attributeTimeouts):
You want to log when there are no timeouts:
Yep, of course.
Thanks for pointing this out.
Line 3676: self.log.warning('monitor responsive again')
Line 3677:
Line 3678: @property
Line 3679: def monitorResponse(self):
--
To view, visit
http://gerrit.ovirt.org/23138
To unsubscribe, visit
http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I32a98d34cde91fa9dc3d07f03c47a5f2f22da620
Gerrit-PatchSet: 6
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani <fromani(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani(a)redhat.com>
Gerrit-Reviewer: Michal Skrivanek <michal.skrivanek(a)redhat.com>
Gerrit-Reviewer: Nir Soffer <nsoffer(a)redhat.com>
Gerrit-Reviewer: Vinzenz Feenstra <vfeenstr(a)redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes