Adam Litke has posted comments on this change.
Change subject: MOM Integration
......................................................................
Patch Set 9: I would prefer that you didn't submit this
(10 inline comments)
....................................................
File Makefile.am
Line 56: vdsm_cli/vdsClient.py \
Please help keep these sorted.
Line 60:
No need to add whitespace here.
....................................................
File vdsm/clientIF.py
Line 70: self.memOvercommit = None
This variable name should make it more obvious what it is. How about naming it
MOMController ?
....................................................
File vdsm/ksm.py
Line 28: class KsmMonitorThread(momBase):
I am not sure I like having this thread inherit from a MomBase class. The
KsmMonitorThread is on its way to deprecation so we should leave this class as-is. I
would rather see if statements in the few areas of the code that check if MOM is
initialized and fall back to ksmThread as necessary.
....................................................
File vdsm/libvirtvm.py
Line 2050: self.cif.memOvercommit.adjust()
I don't understand this adjust call. It seems to be a no-op.
....................................................
File vdsm/mom.conf
Line 45: policy: /etc/vdsm/mom.policy
Maybe build this value using autoconf and use the @confdir@ variable.
Line 51: log: /var/log/vdsm/mom.log
Same as above
....................................................
File vdsm/vdsMOM.py
Line 25: class momBase(threading.Thread):
This is not a great abstraction in my opinion. The KsmMonitorThread really has nothing to
do with MOM so I would prefer that we don't try to merge the two things together. Is
there any other reason to have this class around?
....................................................
File vdsm/vm.py
Line 571: if self.lastStatus != 'Don' and 'recover' not in
self.conf:
accidental bug addition: s/Don/Down/
Line 572: self.cif.memOvercommit.adjust()
Just add an if statement here to see if you should use MOM or KsmMonitorThread.
Basically, if ksmMonitor is not None, call its adjust method.
--
To view, visit
http://gerrit.ovirt.org/2367
To unsubscribe, visit
http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I61e68f72e9115a913d5bc0f4903b906b0d0cce2f
Gerrit-PatchSet: 9
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Mark Wu <wudxw(a)linux.vnet.ibm.com>
Gerrit-Reviewer: Adam Litke <agl(a)us.ibm.com>
Gerrit-Reviewer: Ayal Baron <abaron(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Doron Fediuck <dfediuck(a)redhat.com>
Gerrit-Reviewer: Mark Wu <wudxw(a)linux.vnet.ibm.com>
Gerrit-Reviewer: Shu Ming <shuming(a)linux.vnet.ibm.com>
Gerrit-Reviewer: Xu He Jie <xuhj(a)linux.vnet.ibm.com>