Yaniv Bronhaim has posted comments on this change.
Change subject: supervdsmServer: using moduleloader for dynamic imports
......................................................................
Patch Set 1:
(1 comment)
https://gerrit.ovirt.org/#/c/61313/1/vdsm/supervdsmServer
File vdsm/supervdsmServer:
Line 258:
Line 259: modules = moduleloader.load_modules(supervdsm_api)
Line 260: for module_name in modules:
Line 261: api_funcs = [f for _, f in modules[module_name].__dict__.iteritems()
Line 262: if callable(f) and getattr(f, 'exposed_api',
False)]
this part is eqvivalent to listPublicFunctions that is used in line 256. can we use such
listPublicFunctions method in moduleloader for both parts?
Line 263: for func in api_funcs:
Line 264: setattr(_SuperVdsm, func.__name__, bind(logDecorator(func)))
Line 265:
Line 266: try:
--
To view, visit
https://gerrit.ovirt.org/61313
To unsubscribe, visit
https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Iba05dc1433fc9c3fea53e17c1c0cae835078233d
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Irit Goihman <igoihman(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
Gerrit-HasComments: Yes