Dan Kenigsberg has posted comments on this change.
Change subject: Makefile: add vdsm-reg-setup.in to pyflakes
......................................................................
Patch Set 1: Code-Review-1
(1 comment)
http://gerrit.ovirt.org/#/c/27025/1/Makefile.am
File Makefile.am:
Line 63:
Line 64: SKIP_PYFLAKES_ERR = "\./vdsm/storage/lvm\.py.*: list comprehension redefines
\
Line 65: 'lv' from line .*"
Line 66:
Line 67: check-local:
precede "find" with
echo /path/to/vdsm-reg-setup.in && \
to have a simpler "find". Please search other scripts that should better be
pyflakesed. Consider adding them to PEP8, too.
Line 68: find . -path './.git' -prune -type f -o \
Line 69: -name '*.py' -o -name '*.py.in' -o \
Line 70: -name 'vdsm-reg-setup.in' | xargs $(PYFLAKES) | \
Line 71: grep -w -v $(SKIP_PYFLAKES_ERR) | \
--
To view, visit
http://gerrit.ovirt.org/27025
To unsubscribe, visit
http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I6be99965f3249374c99c1d4ab71145d571c13921
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Douglas Schilling Landgraf <dougsland(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Dima Kuznetsov <dkuznets(a)redhat.com>
Gerrit-Reviewer: Douglas Schilling Landgraf <dougsland(a)redhat.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes