Vinzenz Feenstra has posted comments on this change.
Change subject: Introduction for caching the parsed domain XML
......................................................................
Patch Set 13:
(3 comments)
http://gerrit.ovirt.org/#/c/17694/13/vdsm/vm.py
File vdsm/vm.py:
Line 484: def getDeviceElements(self, tagName):
Line 485: return self._devices.getElementsByTagName(tagName)
Line 486:
Line 487: @property
Line 488: def hash(self):
correct, it has to be renamed
Done
Line 489: if self.devices and not self._hash:
Line 490: self._hash = str(hash(self._devices.toxml()))
Line 491: return self._hash or '0'
Line 492:
Line 3292:
Line 3293: for snappableDiskDeviceXmlElement in snappableDiskDeviceXmlElements:
Line 3294: self._changeDisk(snappableDiskDeviceXmlElement)
Line 3295:
Line 3296: return parsedSrcDomXML.dom.toxml()
True, I just tried to use the convenience functions of it. It's
probably no
Done
Line 3297:
Line 3298: def _changeDisk(self, diskDeviceXmlElement):
Line 3299: diskType = diskDeviceXmlElement.getAttribute('type')
Line 3300:
Line 4634: pass
Line 4635: return pid
Line 4636:
Line 4637: def _getUnderlyingVmInfo(self):
Line 4638: self._lastXMLDesc = ParsedDomXML(self._dom.XMLDesc(0))
This function used to return self._lastXMLDesc?!
Done
Line 4639:
Line 4640: def _ejectFloppy(self):
Line 4641: if 'volatileFloppy' in self.conf:
Line 4642: utils.rmFile(self.conf['floppy'])
--
To view, visit
http://gerrit.ovirt.org/17694
To unsubscribe, visit
http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I7e106b2f2d3f4160d4e882f1a2880cb1b52fbb22
Gerrit-PatchSet: 13
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Vinzenz Feenstra <vfeenstr(a)redhat.com>
Gerrit-Reviewer: Antoni Segura Puimedon <asegurap(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce(a)redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani(a)redhat.com>
Gerrit-Reviewer: Martin Sivák <msivak(a)redhat.com>
Gerrit-Reviewer: Michal Skrivanek <michal.skrivanek(a)redhat.com>
Gerrit-Reviewer: Nir Soffer <nsoffer(a)redhat.com>
Gerrit-Reviewer: Peter V. Saveliev <svinota.saveliev(a)gmail.com>
Gerrit-Reviewer: Vinzenz Feenstra <vfeenstr(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes