Dan Kenigsberg has posted comments on this change.
Change subject: Define some constants in API.py
......................................................................
Patch Set 1:
I must say that I do not understand the implementation. How is a prospective user of
API.Volume.copy() is going to use these definition? Could you suggest a use case in the
commit message?
Do we really need the 'STRINGS' at the API level? (I hope that) currently they are
limited to the on-disk representation of metadata.
Note that I know too well how the current usage is confusing and needs a change...
--
To view, visit
http://gerrit.ovirt.org/2262
To unsubscribe, visit
http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Iaef19f956ec1d6f83fd48e71a2f0a018505266be
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Adam Litke <agl(a)us.ibm.com>
Gerrit-Reviewer: Adam Litke <agl(a)us.ibm.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Igor Lvovsky <ilvovsky(a)redhat.com>
Gerrit-Reviewer: Saggi Mizrahi <smizrahi(a)redhat.com>