Francesco Romani has posted comments on this change.
Change subject: vdsm: Refactoring of retrieving device info from xml
......................................................................
Patch Set 7:
(1 comment)
http://gerrit.ovirt.org/#/c/17694/7/vdsm/vm.py
File vdsm/vm.py:
Line 2794: self._getUnderlyingBalloonDeviceInfo(devicesXml=devicesXml)
Line 2795: self._getUnderlyingWatchdogDeviceInfo(devicesXml=devicesXml)
Line 2796: self._getUnderlyingSmartcardDeviceInfo(devicesXml=devicesXml)
Line 2797: self._getUnderlyingConsoleDeviceInfo(devicesXml=devicesXml)
Line 2798: self._updateAgentChannels(devicesXml=devicesXml)
Probably better to save this for another patch.
Line 2799: # Obtain info of all unknown devices. Must be last!
Line 2800: self._getUnderlyingUnknownDeviceInfo(devicesXml=devicesXml)
Line 2801:
Line 2802: def _updateAgentChannels(self, devicesXml):
--
To view, visit
http://gerrit.ovirt.org/17694
To unsubscribe, visit
http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I7e106b2f2d3f4160d4e882f1a2880cb1b52fbb22
Gerrit-PatchSet: 7
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Vinzenz Feenstra <vfeenstr(a)redhat.com>
Gerrit-Reviewer: Antoni Segura Puimedon <asegurap(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce(a)redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani(a)redhat.com>
Gerrit-Reviewer: Itamar Heim <iheim(a)redhat.com>
Gerrit-Reviewer: Martin Sivák <msivak(a)redhat.com>
Gerrit-Reviewer: Michal Skrivanek <michal.skrivanek(a)redhat.com>
Gerrit-Reviewer: Peter V. Saveliev <peet(a)redhat.com>
Gerrit-Reviewer: Vinzenz Feenstra <vfeenstr(a)redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes