Bala.FA has posted comments on this change.
Change subject: gluster: Added geo-replication session list and session status
......................................................................
Patch Set 18: Code-Review-1
(1 comment)
http://gerrit.ovirt.org/#/c/18414/18/vdsm/gluster/cli.py
File vdsm/gluster/cli.py:
Line 1128: pairDetail['filesSyncd'] =
pair.find('files_syncd').text
Line 1129: pairDetail['filesPending'] =
pair.find('files_pending').text
Line 1130: pairDetail['bytesPending'] =
pair.find('bytes_pending').text
Line 1131: pairDetail['deletesPending'] =
pair.find('deletes_pending').text
Line 1132: pairDetail['filesSkipped'] =
pair.find('files_skipped').text
If the above five values are added for detail, why can't we have one parser function
where the five values are parsed only if detail=True?
Line 1133: pairs.append(pairDetail)
Line 1134: status['bricks'] = pairs
Line 1135: return status
Line 1136:
--
To view, visit
http://gerrit.ovirt.org/18414
To unsubscribe, visit
http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I4f37f35a5480fbe049a67758e122d4a0c2eba513
Gerrit-PatchSet: 18
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Darshan N <dnarayan(a)redhat.com>
Gerrit-Reviewer: Aravinda VK <avishwan(a)redhat.com>
Gerrit-Reviewer: Bala.FA <barumuga(a)redhat.com>
Gerrit-Reviewer: Better Saggi <bettersaggi(a)gmail.com>
Gerrit-Reviewer: Darshan N <dnarayan(a)redhat.com>
Gerrit-Reviewer: Saggi Mizrahi <smizrahi(a)redhat.com>
Gerrit-Reviewer: Sahina Bose <sabose(a)redhat.com>
Gerrit-Reviewer: Timothy Asir <tjeyasin(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes