Ayal Baron has posted comments on this change.
Change subject: Don't ignore nfs_mount_options in vdsm.conf
......................................................................
Patch Set 2: Looks good to me, approved
I'm not crazy about the fact that the config takes precedence over the engine and not
the other way around, however, engine does not support per-host config so this does enable
users to do this.
Problem is that users changing params in engine also need to remove params from
vdsm.conf.
Anyway, acking since I don't feel strongly enough about it.
--
To view, visit
http://gerrit.ovirt.org/5368
To unsubscribe, visit
http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I3c1d13bfd98a9b41b9728bdcb7f01b3161c26bd8
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Greg Padgett <gpadgett(a)redhat.com>
Gerrit-Reviewer: Ayal Baron <abaron(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Greg Padgett <gpadgett(a)redhat.com>
Gerrit-Reviewer: Saggi Mizrahi <smizrahi(a)redhat.com>