Dan Kenigsberg has posted comments on this change.
Change subject: Move fencing logic out of API.py
......................................................................
Patch Set 4: I would prefer that you didn't submit this
(1 inline comment)
....................................................
File vdsm_api/vdsmapi-schema.json
Line 305: #
Line 306: # Since: 4.10.0
Line 307: ##
Line 308: {'command': {'class': 'Global', 'name':
'fenceNode'},
Line 309: 'data': {'addr': 'str', 'bladePort':
'int', 'agent': 'str', 'username': 'str',
again: it's not always an int.
see the man page for fence_apc(8)
port Physical plug number or name of virtual machine This parameter is always
required.
I'm not 100% sure about the name "bladePort", too. yep, if I had a better
suggestion, I would have stated it.
Line 310: 'password': 'str', 'action':
'FenceNodeAction', '*secure': 'bool',
Line 311: '*options': 'str'},
Line 312: 'returns': {'*power': 'FenceNodePowerStatus'}}
Line 313:
--
To view, visit
http://gerrit.ovirt.org/7190
To unsubscribe, visit
http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I944c6548a42612f705a410fb4290215451bca035
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Saggi Mizrahi <smizrahi(a)redhat.com>
Gerrit-Reviewer: Adam Litke <agl(a)us.ibm.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Saggi Mizrahi <smizrahi(a)redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server