Dan Kenigsberg has posted comments on this change.
Change subject: Move and encapsulate preun section into vdsm-tool
......................................................................
Patch Set 2: I would prefer that you didn't submit this
(2 inline comments)
....................................................
File vdsm/vdsm-unregister.in
Line 1: #!/bin/bash
again: please break this chunk of code into several vdsm-tool verbs.
* one to stop sysv service.
* another to remove "by vdsm" config
* yet another to clear selinux policy changes.
Line 6: /bin/sed -i '/# by vdsm$/d' \
Federico, why don't we clean after ourselves in Fedora? Was this intentional?
--
To view, visit
http://gerrit.ovirt.org/4526
To unsubscribe, visit
http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I4e7b5dc969dfb51e6880b9bb209a363609f5e123
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Lei Li <lilei(a)linux.vnet.ibm.com>
Gerrit-Reviewer: Adam Litke <agl(a)us.ibm.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce(a)redhat.com>
Gerrit-Reviewer: Lei Li <lilei(a)linux.vnet.ibm.com>
Gerrit-Reviewer: Ryan Harper <ryanh(a)us.ibm.com>