From Dan Kenigsberg <danken(a)redhat.com>:
Dan Kenigsberg has submitted this change and it was merged.
Change subject: introduce pylint check
......................................................................
introduce pylint check
pylint is a static code checker.
Run `make pylint` to see if your new code has not introduced new errors.
Note that currently, pylint does not pass quietly on our code base.
There are some known issues and expect to encounter them when you run
pylint targets.
Further note that `make pylint` is very slow, and then was not added to
`make check`. You have to run it excplicitly to enjoy it. But please do.
I can find simple, but painful, glitches.
Change-Id: I85eca67784f82876b262b4452506e0f47486695b
Signed-off-by: Dan Kenigsberg <danken(a)redhat.com>
Signed-off-by: Irit Goihman <igoihman(a)redhat.com>
---
M Makefile.am
M pylintrc
M tox.ini
3 files changed, 355 insertions(+), 269 deletions(-)
Approvals:
Nir Soffer: Looks good to me, approved
Jenkins CI: Passed CI tests
Irit Goihman: Verified
--
To view, visit
https://gerrit.ovirt.org/69345
To unsubscribe, visit
https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I85eca67784f82876b262b4452506e0f47486695b
Gerrit-PatchSet: 16
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Irit Goihman <igoihman(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer <nsoffer(a)redhat.com>
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>