Dan Kenigsberg has posted comments on this change.
Change subject: Move fencing logic out of API.py
......................................................................
Patch Set 7:
(1 comment)
....................................................
File vdsm/fenceAgent.py
Line 17: class FenceStatusCheckError(RuntimeError):
Line 18: pass
Line 19:
Line 20:
Line 21: def _waitForAgent(p, inp, cancelEvent=None):
Can we re-visit this patch, now with deathsignal in mind? It can be greatly simplified.
Line 22: """ Wait until p.pid exits. Kill it if vdsm exists before.
"""
Line 23: try:
Line 24: p.stdin.write(inp)
Line 25: p.stdin.close()
--
To view, visit
http://gerrit.ovirt.org/7190
To unsubscribe, visit
http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I944c6548a42612f705a410fb4290215451bca035
Gerrit-PatchSet: 7
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Saggi Mizrahi <smizrahi(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Saggi Mizrahi <smizrahi(a)redhat.com>
Gerrit-Reviewer: Shu Ming <shuming(a)linux.vnet.ibm.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei(a)redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes