Francesco Romani has posted comments on this change.
Change subject: virt: graphdev: add the GraphicsDevice class
......................................................................
Patch Set 19: Verified+1
fixed recovery and migration at the cost to ad more mess and special case handling in
virt/migration.py and API.py.
As stated in the commit message, all the VDSM<=>VDSM communication uses the new
graphic device representation; IMO it makes less sense the opposite way (e.g. to save/pass
display* params).
Also verified with 27215 and 26987 using an unaware engine 3.5 and vdsClient; all the
following were done an handful of times (in the order of 10 times)
* start/stop VM, verified runs and connects to console using engine; VDSM logs seems OK as
well
* migrated VM while console connected; verified console connects after VM migrated
* restarted VDSM to try recovery without migration, before migration and after migration
on destination host; verified console connects after all those recoveries
* tried suspend/resume, verified console connects afterwards.
verified engine logs, nothing strange found at cursory glance.
--
To view, visit
http://gerrit.ovirt.org/26895
To unsubscribe, visit
http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I82e4414aa3efe7c756ba8ef9b7b47e591613a717
Gerrit-PatchSet: 19
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani <fromani(a)redhat.com>
Gerrit-Reviewer: Antoni Segura Puimedon <asegurap(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce(a)redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani(a)redhat.com>
Gerrit-Reviewer: Frank Kobzik <fkobzik(a)redhat.com>
Gerrit-Reviewer: Martin Polednik <mpoledni(a)redhat.com>
Gerrit-Reviewer: Michal Skrivanek <michal.skrivanek(a)redhat.com>
Gerrit-Reviewer: Vinzenz Feenstra <vfeenstr(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No