Antoni Segura Puimedon has posted comments on this change.
Change subject: vdsm: Refactoring of retrieving device info from xml
......................................................................
Patch Set 2:
(1 comment)
A very minor comment.
As a side note, I feel that there is potential for doing all this xml handling happen more
implicitly without passing the stuff around.
....................................................
File vdsm/vm.py
Line 2730: def _getUnderlyingVmDevicesInfo(self):
Line 2731: """
Line 2732: Obtain underlying vm's devices info from libvirt.
Line 2733: """
Line 2734: devicesXml = self._getDevicesXml(parsedXml=self._lastParsedXmlDesc)
wouldn't it be the same without passing it?
Line 2735: self._getUnderlyingNetworkInterfaceInfo(devicesXml=devicesXml)
Line 2736: self._getUnderlyingDriveInfo(devicesXml=devicesXml)
Line 2737: self._getUnderlyingDisplayPort(xml=self._lastParsedXmlDesc)
Line 2738: self._getUnderlyingSoundDeviceInfo(devicesXml=devicesXml)
--
To view, visit
http://gerrit.ovirt.org/17694
To unsubscribe, visit
http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I7e106b2f2d3f4160d4e882f1a2880cb1b52fbb22
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Vinzenz Feenstra <vfeenstr(a)redhat.com>
Gerrit-Reviewer: Antoni Segura Puimedon <asegurap(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce(a)redhat.com>
Gerrit-Reviewer: Martin Sivák <msivak(a)redhat.com>
Gerrit-Reviewer: Michal Skrivanek <michal.skrivanek(a)redhat.com>
Gerrit-Reviewer: Peter V. Saveliev <peet(a)redhat.com>
Gerrit-Reviewer: Vinzenz Feenstra <vfeenstr(a)redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes