Saggi Mizrahi has posted comments on this change.
Change subject: Refactor storage connection subsystem
......................................................................
Patch Set 10: (6 inline comments)
....................................................
File vdsm/storage/hsm.py
Line 1858: ac = self._connectionMonitor.manage(uri, uri)
I actually use the uri as the ID because I don't get a unique ID and this is pretty
unique for the connection
Line 1871: status = 200
I'ts on my todo list
Line 1906: """
F**ing rebase
Line 1915: ac = self._connectionMonitor.unmanage(uri)
As I said, I'm using the uri as ID in the backward compatible functions
....................................................
File vdsm/storage/storageProviderConnectionMonitor.py
Line 117: return tuple(params)
I'm removing this entire thing in future patches. We decided not to continue with
URIs. Just leave it be
Line 146: return url[i:j]
I'm removing this entire thing in future patches. We decided not to continue with
URIs. Just leave it be
--
To view, visit
http://gerrit.ovirt.org/1038
To unsubscribe, visit
http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ifc5c160aba9b4cc88225dde0c44f9b766c6a4c0d
Gerrit-PatchSet: 10
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Saggi Mizrahi <smizrahi(a)redhat.com>
Gerrit-Reviewer: Ayal Baron <abaron(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Ewoud Kohl van Wijngaarden <ewoud(a)kohlvanwijngaarden.nl>
Gerrit-Reviewer: Federico Simoncelli <fsimonce(a)redhat.com>
Gerrit-Reviewer: Igor Lvovsky <ilvovsky(a)redhat.com>
Gerrit-Reviewer: Saggi Mizrahi <smizrahi(a)redhat.com>