Dan Kenigsberg has posted comments on this change.
Change subject: Added blkid tool into constants.
......................................................................
Patch Set 1: I would prefer that you didn't submit this
Hi Bala,
Just adding constants is a bit pointless - we'd better include some code that uses
them. Particularly when this adds stuff to our evil sudoers file.
Best practice would be to add a blkid.py file exposing blkid functionality in python.
Then, preferably add a superVdsm function that uses it.
--
To view, visit
http://gerrit.ovirt.org/2185
To unsubscribe, visit
http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia9ad51df4f4b98e2aff5db1d9c02512045977a60
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Bala.FA <barumuga(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Saggi Mizrahi <smizrahi(a)redhat.com>