Igor Lvovsky has posted comments on this change.
Change subject: Refactor storage connection subsystem
......................................................................
Patch Set 13: Looks good to me, but someone else must approve
(1 inline comment)
Oh, it's so big and complicated.
I have a minor question inline, but it's too big to be revied without your
explanations.
I hope that I didn't missed things.
Is it passed pre-integ?
....................................................
File vdsm/storage/storageServer.py
Line 106: return os.path.join(self.localPathBase,
self._remotePath.replace("/", "_").replace("_",
"__"))
Why we need it? Is it mean that each '/' and '_' will be replaced to
'__' ?
How you will differentiate between '/' an '_' ?
--
To view, visit
http://gerrit.ovirt.org/1038
To unsubscribe, visit
http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ifc5c160aba9b4cc88225dde0c44f9b766c6a4c0d
Gerrit-PatchSet: 13
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Saggi Mizrahi <smizrahi(a)redhat.com>
Gerrit-Reviewer: Ayal Baron <abaron(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Ewoud Kohl van Wijngaarden <ewoud(a)kohlvanwijngaarden.nl>
Gerrit-Reviewer: Federico Simoncelli <fsimonce(a)redhat.com>
Gerrit-Reviewer: Igor Lvovsky <ilvovsky(a)redhat.com>
Gerrit-Reviewer: Saggi Mizrahi <smizrahi(a)redhat.com>