Nir Soffer has posted comments on this change.
Change subject: Live Merge: Restore watermark tracking
......................................................................
Patch Set 3:
(2 comments)
http://gerrit.ovirt.org/#/c/36924/3/vdsm/virt/vm.py
File vdsm/virt/vm.py:
Line 712: 'writeLatency': str(compute_latency('wr')),
Line 713: 'flushLatency': str(compute_latency('flush'))}
Line 714:
Line 715:
Line 716: def _vmsGetBulkStats(conn, vmList, statsTypes=0, statsFlags=0):
ok.
Previously I missed the fact that this returns stats for
*some* vms and not all of them, so this should not be _getAllVMsBulkStats but
_getVMsBulkStats.
Line 717: domList = [x._dom._dom for x in vmList]
Line 718: if statsTypes == 0:
Line 719: statsTypes = (libvirt.VIR_DOMAIN_STATS_STATE |
Line 720: libvirt.VIR_DOMAIN_STATS_CPU_TOTAL |
Line 1419: self.conf['timeOffset'] = newTimeOffset
Line 1420:
Line 1421: def _getBulkStats(self, statsTypes, statsFlags):
Line 1422: return _vmsGetBulkStats(self._connection, [self], statsTypes,
Line 1423: statsFlags)[self.id]
Yes this is a good long-term idea but I am not sure I want to commit
to it
I see now that this get the stats for only one vm ([self]), so this fine.
Line 1424:
Line 1425: def _getWriteWatermarks(self):
Line 1426: def pathToVolID(drive, path):
Line 1427: for vol in drive.volumeChain:
--
To view, visit
http://gerrit.ovirt.org/36924
To unsubscribe, visit
http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I632f31e7795ec5d8c6f52a480116b14470c3163f
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Adam Litke <alitke(a)redhat.com>
Gerrit-Reviewer: Adam Litke <alitke(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce(a)redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani(a)redhat.com>
Gerrit-Reviewer: Nir Soffer <nsoffer(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes