Federico Simoncelli has posted comments on this change.
Change subject: remove symlink when connect local storage failed
......................................................................
Patch Set 1:
(1 comment)
....................................................
File vdsm/storage/storageServer.py
Line 418: if self.checkLink():
Line 419: return
Line 420: try:
Line 421: lnPath = self._getLocalPath()
Line 422: os.symlink(self._path, lnPath)
I suppose the "try:" should go here.
Line 423: os.chmod(lnPath, 0775)
Line 424: except OSError:
Line 425: os.unlink(lnPath)
Line 426: raise
--
To view, visit
http://gerrit.ovirt.org/6140
To unsubscribe, visit
http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I0e44605fb6c6e2512a6aa1acefb3d1d7e09a67aa
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Royce Lv <lvroyce(a)linux.vnet.ibm.com>
Gerrit-Reviewer: Ayal Baron <abaron(a)redhat.com>
Gerrit-Reviewer: Better Saggi <bettersaggi(a)gmail.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce(a)redhat.com>
Gerrit-Reviewer: Itamar Heim <iheim(a)redhat.com>
Gerrit-Reviewer: Mark Wu <wudxw(a)linux.vnet.ibm.com>
Gerrit-Reviewer: Saggi Mizrahi <smizrahi(a)redhat.com>
Gerrit-HasComments: Yes