Ryan Harper has posted comments on this change.
Change subject: Remove rhevm from vds_bootstrap/
......................................................................
Patch Set 1: (1 inline comment)
....................................................
File vds_bootstrap/vds_bootstrap.py
Line 926: print "<BSTRAP component='OVIRT_INSTALL'
status='FAIL'/>"
Why would downstream (distro) vdsm-bootstrap include these upstream bits? Would you also
update vdsm without also updating RHEVM? Wouldn't we modify RHEVM/engine to support
either string? It would consider the RHEV_INSTALL string as legacy and I don't see
any reason it couldn't support the OVIRT_INSTALL string as well.
Textstrings don't make an robust API; we're just both saying that this element
needs to be more robust. To be fair, I've not read the counterpart-code in engine yet
to see why it's doing string parsing during this procedure. I'll go take a look
at that part today.
--
To view, visit
http://gerrit.ovirt.org/3287
To unsubscribe, visit
http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib28617f0fa45ff867fcd85eeb7bd49d8d5220d4d
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Ryan Harper <ryanh(a)us.ibm.com>
Gerrit-Reviewer: Adam Litke <agl(a)us.ibm.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Ryan Harper <ryanh(a)us.ibm.com>