Dan Kenigsberg has posted comments on this change.
Change subject: virt: graphdev: add the GraphicsDevice class
......................................................................
Patch Set 20:
(1 comment)
http://gerrit.ovirt.org/#/c/26895/20/vdsm/virt/migration.py
File vdsm/virt/migration.py:
Line 193:
Line 194: def _patchConfigForGraphics(self):
Line 195: """
Line 196: the first graphic device, the one which overlaps with the display*
Line 197: params, must NOT be declared as real device to not break clusterLevel.
It would be much simpler to limit this logic to the construct_from_legacy code: if any
graphics device exists in conf, display* should be ignored.
Line 198: """
Line 199: self._machineParams['devices'] =
self._vm.filterDevicesForMigration(
Line 200: self._machineParams['devices'][:],
self._machineParams['display'])
Line 201:
--
To view, visit
http://gerrit.ovirt.org/26895
To unsubscribe, visit
http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I82e4414aa3efe7c756ba8ef9b7b47e591613a717
Gerrit-PatchSet: 20
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani <fromani(a)redhat.com>
Gerrit-Reviewer: Antoni Segura Puimedon <asegurap(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce(a)redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani(a)redhat.com>
Gerrit-Reviewer: Frank Kobzik <fkobzik(a)redhat.com>
Gerrit-Reviewer: Martin Polednik <mpoledni(a)redhat.com>
Gerrit-Reviewer: Michal Skrivanek <michal.skrivanek(a)redhat.com>
Gerrit-Reviewer: Vinzenz Feenstra <vfeenstr(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes