Francesco Romani has posted comments on this change.
Change subject: static: move vdsm bonding defaults under static
......................................................................
Patch Set 6: Code-Review+1
(1 comment)
Moving to static/ -> +2
hardcoding paths? not really sure. So just +1 for now :)
https://gerrit.ovirt.org/#/c/62537/6/static/Makefile.am
File static/Makefile.am:
PS6, Line 24: /usr/share
Don't we have a predefined variable for this?
sharedir? sharedir_DATA?
something like this
--
To view, visit
https://gerrit.ovirt.org/62537
To unsubscribe, visit
https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I9cbd81e59aec49876e15337d7cd617e51316a604
Gerrit-PatchSet: 6
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Martin Polednik <mpolednik(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Polednik <mpolednik(a)redhat.com>
Gerrit-Reviewer: Ondřej Svoboda <osvoboda(a)redhat.com>
Gerrit-Reviewer: Petr Horáček <phoracek(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
Gerrit-HasComments: Yes