Nir Soffer has posted comments on this change.
Change subject: hsm: Reformat device info dict
......................................................................
Patch Set 1:
(1 comment)
https://gerrit.ovirt.org/#/c/45845/1/vdsm/storage/hsm.py
File vdsm/storage/hsm.py:
Line 2024: pvsize = ""
Line 2025: vguuid = ""
Line 2026:
Line 2027: devInfo = {
Line 2028: "serial": dev.get("serial", ""),
If it is sorted, "serial" should not be first.
Thanks, will fix ( " < ' )
Line 2029: 'GUID': dev.get("guid", ""),
Line 2030: 'capacity': dev.get("capacity",
"0"),
Line 2031: 'devtype': dev.get("devtype", ""),
Line 2032: 'fwrev': dev.get("fwrev", ""),
--
To view, visit
https://gerrit.ovirt.org/45845
To unsubscribe, visit
https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic285575545ccdbe449d1c6b95f5874f8e15711ce
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer <nsoffer(a)redhat.com>
Gerrit-Reviewer: Adam Litke <alitke(a)redhat.com>
Gerrit-Reviewer: Ala Hino <ahino(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Freddy Rolland <frolland(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer <nsoffer(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-HasComments: Yes