Dan Kenigsberg has posted comments on this change.
Change subject: tests: add simple balloon functional testcase
......................................................................
Patch Set 7: Code-Review-1
(1 comment)
http://gerrit.ovirt.org/#/c/12820/7/tests/functional/virtTests.py
File tests/functional/virtTests.py:
Line 440: vm)['statsList'][0]['balloonInfo']
Line 441: self.assertEqual(balloonInfo['balloon_cur'], 0)
Line 442:
Line 443: def _balloonPolicy(self, policy):
Line 444: with RollbackContext() as rollback:
Please consider replacing with a plain
self.assertVdsOK(self.vdsm.setMOMPolicy(policy)
try:
yeild
finally:
self.assertVdsOK(self.vdsm.resetMOMPolicy())
Line 445: r = self.vdsm.setMOMPolicy(policy)
Line 446: self.assertVdsOK(r)
Line 447: undo = lambda: \
Line 448: self.assertVdsOK(self.vdsm.resetMOMPolicy())
--
To view, visit
http://gerrit.ovirt.org/12820
To unsubscribe, visit
http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie8140fe1c754d9d4026c503a19420e6552a3f4fe
Gerrit-PatchSet: 7
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Royce Lv <lvroyce(a)linux.vnet.ibm.com>
Gerrit-Reviewer: Adam Litke <alitke(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Doron Fediuck <dfediuck(a)redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani(a)redhat.com>
Gerrit-Reviewer: Martin Sivák <msivak(a)redhat.com>
Gerrit-Reviewer: Michal Skrivanek <michal.skrivanek(a)redhat.com>
Gerrit-Reviewer: Royce Lv <lvroyce(a)linux.vnet.ibm.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes