Igor Lvovsky has posted comments on this change.
Change subject: Refactor storage connection subsystem
......................................................................
Patch Set 10: I would prefer that you didn't submit this
(14 inline comments)
....................................................
File vdsm.spec.in
Line 486: %{_datadir}/%{vdsm_name}/storage/storageProviderConnectionMonitor.py*
I think you sorted it by yourself
....................................................
File vdsm/storage/hsm.py
Line 127: # ISCSI domain shouldn't even be on the list but VDSM use to just
ISCSI ->FCP
Line 1858: ac = self._connectionMonitor.manage(uri, uri)
according to signature: def manage(self, uri, conId)
Should it be
ac = self._connectionMonitor.manage(uri, conId) ?
Line 1871: status = 200
Can you please use the proper error code from storage_exception.py ?
Something like se.XXX.code
Line 1897: corosponding domains type
corosponding -> coresponding
Line 1900: with keys depnding ont the type
depnding -> depending, ont -> on
Line 1906: """
I already wrote this, but you ignored it.
You fixed in your prev patch (
http://gerrit.ovirt.org/#change,1098) same doc string in
connectStorageServer. Please consider to squash these two patches.
Line 1915: ac = self._connectionMonitor.unmanage(uri)
the signature is: def unmanage(self, conId).
So, should it be self._connectionMonitor.unmanage(conId) ?
Line 1927: status = 200
Can you please use the proper error code from storage_exception.py ? Something like
se.XXX.code
....................................................
File vdsm/storage/storageProviderConnectionMonitor.py
Line 117: return tuple(params)
I am not sure, but did you addressed Ewoud's comments from patchset 8 ?
Line 146: return url[i:j]
Same as above
Line 186: raise ValueError("Custom login is not supported")
login -> password
Line 266: raise ValueError("Custom login is not supported")
login -> password
Line 465: raise ValueError("Custom login is not supported")
login -> password
--
To view, visit
http://gerrit.ovirt.org/1038
To unsubscribe, visit
http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ifc5c160aba9b4cc88225dde0c44f9b766c6a4c0d
Gerrit-PatchSet: 10
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Saggi Mizrahi <smizrahi(a)redhat.com>
Gerrit-Reviewer: Ayal Baron <abaron(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Ewoud Kohl van Wijngaarden <ewoud(a)kohlvanwijngaarden.nl>
Gerrit-Reviewer: Federico Simoncelli <fsimonce(a)redhat.com>
Gerrit-Reviewer: Igor Lvovsky <ilvovsky(a)redhat.com>
Gerrit-Reviewer: Saggi Mizrahi <smizrahi(a)redhat.com>