From Yaniv Bronhaim <ybronhei(a)redhat.com>:
Yaniv Bronhaim has posted comments on this change.
Change subject: tests: ThreadLeakPlugin
......................................................................
Patch Set 7: Code-Review-1
(3 comments)
can be that I miss some parts of this implementation?
https://gerrit.ovirt.org/#/c/69040/7/tests/testValidation.py
File tests/testValidation.py:
Line 1: #
Line 2: # Copyright 2009-2014 Red Hat, Inc.
dates
Line 3: #
Line 4: # This program is free software; you can redistribute it and/or modify
Line 5: # it under the terms of the GNU General Public License as published by
Line 6: # the Free Software Foundation; either version 2 of the License, or
Line 89: if options.enable_stress_tests:
Line 90: StressTestsPlugin.enabled = True
Line 91:
Line 92:
Line 93: class ThreadLeakPlugin(Plugin):
""" All plugins must implement the methods options(self, parser, env) and
configure(self, options, conf). Subclasses of nose.plugins.Plugin that want the standard
options should call the superclass methods. """
Line 94: """
Line 95: Check whether a test (or the code it triggers) leaks threads
Line 96: """
Line 97: name = 'thread-leak-check'
https://gerrit.ovirt.org/#/c/69040/7/tests/testlib.py
File tests/testlib.py:
Line 1: #
Line 2: # Copyright 2012-2016 Red Hat, Inc.
dates
Line 3: #
Line 4: # This program is free software; you can redistribute it and/or modify
Line 5: # it under the terms of the GNU General Public License as published by
Line 6: # the Free Software Foundation; either version 2 of the License, or
--
To view, visit
https://gerrit.ovirt.org/69040
To unsubscribe, visit
https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I4347f5a6ccf02e80d86174c979eb85a0c5076e7a
Gerrit-PatchSet: 7
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Irit Goihman <igoihman(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer <nsoffer(a)redhat.com>
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
Gerrit-HasComments: Yes