Dan Kenigsberg has posted comments on this change.
Change subject: make compression type configurable, support gzip and xz
......................................................................
Patch Set 1: I would prefer that you didn't submit this
(1 inline comment)
Goodness, I was way too quick with my -2. I beg your pardon. I thought you are about to
support gz compression of log files.
Still, I do not see the grand benefit from this. Is it commonplace for `make dist` to
generate a tar.xz?
....................................................
File configure.ac
Line 42: support_xz=false
that's a misleading name (at least it mislead me). Even when false, xz is used by
vdsm.
--
To view, visit
http://gerrit.ovirt.org/4174
To unsubscribe, visit
http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I4d88e9d40aefc87564c9c7e23f0d28aaad867aca
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: ShaoHe Feng <shaohef(a)linux.vnet.ibm.com>
Gerrit-Reviewer: Adam Litke <agl(a)us.ibm.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Mark Wu <wudxw(a)linux.vnet.ibm.com>
Gerrit-Reviewer: Ryan Harper <ryanh(a)us.ibm.com>
Gerrit-Reviewer: Shu Ming <shuming(a)linux.vnet.ibm.com>