Lei Li has posted comments on this change.
Change subject: Move and encapsulate preun section into vdsm-tool
......................................................................
Patch Set 6: (1 inline comment)
Shaohe:
Please give more details about which vdsm-tool command failed..and the which os you used,
thanks.
....................................................
File vdsm_tool/passwd.py
Line 56: constants.SASL_USERNAME])
Seems vdsm spec file already has the check for this shell command:
"Requires(post): /usr/sbin/saslpasswd2"
Can you let me know the reason for this action as your comment?
--
To view, visit
http://gerrit.ovirt.org/4526
To unsubscribe, visit
http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I4e7b5dc969dfb51e6880b9bb209a363609f5e123
Gerrit-PatchSet: 6
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Lei Li <lilei(a)linux.vnet.ibm.com>
Gerrit-Reviewer: Adam Litke <agl(a)us.ibm.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce(a)redhat.com>
Gerrit-Reviewer: Lei Li <lilei(a)linux.vnet.ibm.com>
Gerrit-Reviewer: Ryan Harper <ryanh(a)us.ibm.com>
Gerrit-Reviewer: ShaoHe Feng <shaohef(a)linux.vnet.ibm.com>
Gerrit-Reviewer: Wenyi Gao <wenyi(a)linux.vnet.ibm.com>