Ewoud Kohl van Wijngaarden has posted comments on this change.
Change subject: Refactor storage connection subsystem
......................................................................
Patch Set 8: (2 inline comments)
Partial review, but I feel this code could be much simplified by using urlparse.
....................................................
File vdsm/storage/storageProviderConnectionMonitor.py
Line 117: return tuple(params)
It feels like you're implementing urlparse.parse_qs here.
Line 146: return url[i:j]
Again, this feels a lot like implementing urlparse.urlparse.
>> parsed =
urlparse.urlparse('iscsi://user:pass@hostname.example.org/iqn;portal=3')
>> (parsed.hostname or "") + parsed.path.split(';', 1)[0]
'hostname.example.org/iqn'
The or "" is needed for file:// where there is no hostname.
--
To view, visit
http://gerrit.ovirt.org/1038
To unsubscribe, visit
http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ifc5c160aba9b4cc88225dde0c44f9b766c6a4c0d
Gerrit-PatchSet: 8
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Saggi Mizrahi <smizrahi(a)redhat.com>
Gerrit-Reviewer: Ayal Baron <abaron(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Ewoud Kohl van Wijngaarden <ewoud(a)kohlvanwijngaarden.nl>
Gerrit-Reviewer: Federico Simoncelli <fsimonce(a)redhat.com>
Gerrit-Reviewer: Igor Lvovsky <ilvovsky(a)redhat.com>
Gerrit-Reviewer: Saggi Mizrahi <smizrahi(a)redhat.com>