Francesco Romani has posted comments on this change.
Change subject: Introduction for caching the parsed domain XML
......................................................................
Patch Set 18:
(2 comments)
I'm fine with the domain_descriptor.py;
but just a wild idea, maybe merge into the new xmldom module?
http://gerrit.ovirt.org/#/c/26855/2
http://gerrit.ovirt.org/#/c/17694/18/vdsm/virt/vm.py
File vdsm/virt/vm.py:
Line 1855: self.conf['vmName'] = 'n%s' % self.id
Line 1856: self._guestSocketFile = self._makeChannelPath(_VMCHANNEL_DEVICE_NAME)
Line 1857: self._qemuguestSocketFile =
self._makeChannelPath(_QEMU_GA_DEVICE_NAME)
Line 1858: self._lastXMLDesc = DomainDescriptor(
Line 1859: '<domain><uuid>%s</uuid></domain>'
% self.id)
Lets move this hack into domaindescrioptor module and call it
something lik
+1
Line 1860: self._released = False
Line 1861: self._releaseLock = threading.Lock()
Line 1862: self.saveState()
Line 1863: self._watchdogEvent = {}
Line 4661: return pid
Line 4662:
Line 4663: def _getUnderlyingVmInfo(self):
Line 4664: domainXML = self._dom.XMLDesc(0)
Line 4665: self._lastXMLDesc = DomainDescriptor(domainXML)
Now we need the return value: see _lookupDeviceXMLByAlias
Line 4666:
Line 4667: def _ejectFloppy(self):
Line 4668: if 'volatileFloppy' in self.conf:
Line 4669: utils.rmFile(self.conf['floppy'])
--
To view, visit
http://gerrit.ovirt.org/17694
To unsubscribe, visit
http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I7e106b2f2d3f4160d4e882f1a2880cb1b52fbb22
Gerrit-PatchSet: 18
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Vinzenz Feenstra <vfeenstr(a)redhat.com>
Gerrit-Reviewer: Antoni Segura Puimedon <asegurap(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce(a)redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani(a)redhat.com>
Gerrit-Reviewer: Martin Sivák <msivak(a)redhat.com>
Gerrit-Reviewer: Michal Skrivanek <michal.skrivanek(a)redhat.com>
Gerrit-Reviewer: Nir Soffer <nsoffer(a)redhat.com>
Gerrit-Reviewer: Peter V. Saveliev <svinota.saveliev(a)gmail.com>
Gerrit-Reviewer: Vinzenz Feenstra <vfeenstr(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes