Piotr Kliczewski has posted comments on this change.
Change subject: yml: parameter type fixes for StoragePool.connectStorageServer
......................................................................
Patch Set 1:
(1 comment)
https://gerrit.ovirt.org/#/c/59701/1/lib/api/vdsm-api.yml
File lib/api/vdsm-api.yml:
Line 5536: description: An enumeration of Storage Domain types.
Line 5537: name: StorageDomainType
Line 5538: type: enum
Line 5539: values:
Line 5540: 2: The Storage Domain uses FibreChannel based storage
Any reason not to have it sorted by value ?
No reason, will
update
Line 5541: 3: The Storage Domain uses iSCSI based storage
Line 5542: 4: The Storage Domain uses storage on the local file system
Line 5543: 1: The Storage Domain uses Network File System based storage
Line 5544: 0: The type is not known
--
To view, visit
https://gerrit.ovirt.org/59701
To unsubscribe, visit
https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: If9fe2ffc3bc2327eefaae794b7b366e8202d2f2a
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Piotr Kliczewski <piotr.kliczewski(a)gmail.com>
Gerrit-Reviewer: Adam Litke <alitke(a)redhat.com>
Gerrit-Reviewer: Freddy Rolland <frolland(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer <nsoffer(a)redhat.com>
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
Gerrit-HasComments: Yes