Ryan Harper has posted comments on this change.
Change subject: make compression type configurable, support gzip and xz
......................................................................
Patch Set 1:
If a distro/system doesn't have xz, then it would use gzip for packaging and for
compressing the log files. But that's really a host env issue, vdsm shouldn't
care (doesn't?) what compression is used. Looks like the logrotate stuff has some xz
stuff and that's about it.
Making it configurable only means that on environments that do not provide 'xz'
they can use gzip. This should have no effect on downstreams that provide 'xz'
--
To view, visit
http://gerrit.ovirt.org/4174
To unsubscribe, visit
http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I4d88e9d40aefc87564c9c7e23f0d28aaad867aca
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: ShaoHe Feng <shaohef(a)linux.vnet.ibm.com>
Gerrit-Reviewer: Adam Litke <agl(a)us.ibm.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Mark Wu <wudxw(a)linux.vnet.ibm.com>
Gerrit-Reviewer: Ryan Harper <ryanh(a)us.ibm.com>
Gerrit-Reviewer: Shu Ming <shuming(a)linux.vnet.ibm.com>