Tomas Golembiovsky has posted comments on this change.
Change subject: v2v: support for block devices
......................................................................
Patch Set 4: Code-Review-1
(1 comment)
As pointed out by a user on ML the change breaks engine. VDSM fails to fetch disk size and
logs an exception. Although the the disk size field is marked as optional in the scheme
engine does not consider the size opotional aparently.
Maybe we should provide an alternative logic of fetching disk size for block devices.
Adding -1 for the moment.
https://gerrit.ovirt.org/#/c/64272/2/tests/v2vTests.py
File tests/v2vTests.py:
PS2, Line 130: {dis
yes,
Are you sure? Based on what I see in docs it's more
like file attribute is for file and dev attribute is for block.
--
To view, visit
https://gerrit.ovirt.org/64272
To unsubscribe, visit
https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I5f7a85715764efded7b296e858b130a05fe10f2a
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Shahar Havivi <shavivi(a)redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Shahar Havivi <shavivi(a)redhat.com>
Gerrit-Reviewer: Tomas Golembiovsky <tgolembi(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
Gerrit-HasComments: Yes