Michal Skrivanek has posted comments on this change.
Change subject: vdsm: Refactoring of retrieving device info from xml
......................................................................
Patch Set 4:
(2 comments)
....................................................
File vdsm/vm.py
Line 1697: self.conf['vmName'] = 'n%s' % self.id
Line 1698: self._guestSocketFile = self._makeChannelPath(_VMCHANNEL_DEVICE_NAME)
Line 1699: self._qemuguestSocketFile =
self._makeChannelPath(_QEMU_GA_DEVICE_NAME)
Line 1700: self._lastXMLDesc =
'<domain><uuid>%s</uuid></domain>' % self.id
Line 1701: self._lastParsedXmlDesc = _domParseStr(self._lastXMLDesc)
can we maybe keep it together? or do we still need the last non-parsed xml?
Line 1702: self._devXmlHash = '0'
Line 1703: self._released = False
Line 1704: self._releaseLock = threading.Lock()
Line 1705: self.saveState()
Line 2742: self._getUnderlyingBalloonDeviceInfo(devicesXml=devicesXml)
Line 2743: self._getUnderlyingWatchdogDeviceInfo(devicesXml=devicesXml)
Line 2744: self._getUnderlyingSmartcardDeviceInfo(devicesXml=devicesXml)
Line 2745: self._getUnderlyingConsoleDeviceInfo(devicesXml=devicesXml)
Line 2746: # Obtain info of all unknown devices. Must be last!
is it?;-)
Line 2747: self._getUnderlyingUnknownDeviceInfo(devicesXml=devicesXml)
Line 2748: self._updateAgentChannels(devicesXml=devicesXml)
Line 2749:
Line 2750: def _updateAgentChannels(self, devicesXml):
--
To view, visit
http://gerrit.ovirt.org/17694
To unsubscribe, visit
http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I7e106b2f2d3f4160d4e882f1a2880cb1b52fbb22
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Vinzenz Feenstra <vfeenstr(a)redhat.com>
Gerrit-Reviewer: Antoni Segura Puimedon <asegurap(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce(a)redhat.com>
Gerrit-Reviewer: Martin Sivák <msivak(a)redhat.com>
Gerrit-Reviewer: Michal Skrivanek <michal.skrivanek(a)redhat.com>
Gerrit-Reviewer: Peter V. Saveliev <peet(a)redhat.com>
Gerrit-Reviewer: Vinzenz Feenstra <vfeenstr(a)redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes