Dan Kenigsberg has posted comments on this change.
Change subject: vm: Fix attribute error when accessing drive in sampling method
......................................................................
Patch Set 1:
(1 comment)
....................................................
Commit Message
Line 6:
Line 7: vm: Fix attribute error when accessing drive in sampling method
Line 8:
Line 9: Du to race when migration is finished and monitoring, drive may not have
Line 10: a format attribute when accessing it from the monitor. This patch use
Could you elaborate on the nature of this race? Is it complex to solve (and hence better
be left for a future patch)?
Line 11: getattr to log spam.
Line 12:
Line 13: Change-Id: Ia50e8af94b9c9b54332066a3f30999ce73e7a56f
--
To view, visit
http://gerrit.ovirt.org/22518
To unsubscribe, visit
http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia50e8af94b9c9b54332066a3f30999ce73e7a56f
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-3.3
Gerrit-Owner: Nir Soffer <nsoffer(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce(a)redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani(a)redhat.com>
Gerrit-Reviewer: Nir Soffer <nsoffer(a)redhat.com>
Gerrit-Reviewer: Sergey Gotliv <sgotliv(a)redhat.com>
Gerrit-Reviewer: Vinzenz Feenstra <vfeenstr(a)redhat.com>
Gerrit-HasComments: Yes