Nir Soffer has posted comments on this change.
Change subject: virt: introduce caching the parsed domain XML
......................................................................
Patch Set 26:
(2 comments)
http://gerrit.ovirt.org/#/c/17694/26/vdsm/virt/domain_descriptor.py
File vdsm/virt/domain_descriptor.py:
Line 40: @property
Line 41: def dom(self):
Line 42: return self._dom
Line 43:
Line 44: def firstElementByTagName(self, tagName):
This should be private as Dan suggested in the previous version.
Line 45: elements = self._dom.childNodes[0].getElementsByTagName(tagName)
Line 46: return elements[0] if elements else None
Line 47:
Line 48: @property
http://gerrit.ovirt.org/#/c/17694/26/vdsm/virt/vm.py
File vdsm/virt/vm.py:
Line 5045: def _getUnderlyingNetworkInterfaceInfo(self):
Line 5046: """
Line 5047: Obtain network interface info from libvirt.
Line 5048: """
Line 5049: # TODO use xpath instead of parseString (here and elsewhere)
This comment is unneeded now.
Line 5050: for x in self._domain.getDeviceElements('interface'):
Line 5051: devType = x.getAttribute('type')
Line 5052: mac =
x.getElementsByTagName('mac')[0].getAttribute('address')
Line 5053: alias =
x.getElementsByTagName('alias')[0].getAttribute('name')
--
To view, visit
http://gerrit.ovirt.org/17694
To unsubscribe, visit
http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I7e106b2f2d3f4160d4e882f1a2880cb1b52fbb22
Gerrit-PatchSet: 26
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Vinzenz Feenstra <vfeenstr(a)redhat.com>
Gerrit-Reviewer: Antoni Segura Puimedon <asegurap(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Ewoud Kohl van Wijngaarden <ewoud(a)kohlvanwijngaarden.nl>
Gerrit-Reviewer: Federico Simoncelli <fsimonce(a)redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani(a)redhat.com>
Gerrit-Reviewer: Martin Sivák <msivak(a)redhat.com>
Gerrit-Reviewer: Michal Skrivanek <michal.skrivanek(a)redhat.com>
Gerrit-Reviewer: Nir Soffer <nsoffer(a)redhat.com>
Gerrit-Reviewer: Peter V. Saveliev <svinota.saveliev(a)gmail.com>
Gerrit-Reviewer: Vinzenz Feenstra <vfeenstr(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes