Vinzenz Feenstra has posted comments on this change.
Change subject: Allow GZIP transport on XMLRPC
......................................................................
Patch Set 1:
(2 comments)
http://gerrit.ovirt.org/#/c/25201/1/lib/vdsm/utils.py
File lib/vdsm/utils.py:
Line 163:
Line 164: Encode data using the gzip content encoding as described in RFC 1952
Line 165: """
Line 166: f = StringIO()
Line 167: gzf = gzip.GzipFile(mode="wb", fileobj=f, compresslevel=1)
We may like different compression level - did you do any testing with
commo
This is taken directly from python 2.7 stdlib
Line 168: gzf.write(data)
Line 169: gzf.close()
Line 170: encoded = f.getvalue()
Line 171: f.close()
Line 261: else:
Line 262: # got a valid XML RPC response
Line 263: self.send_response(200)
Line 264: self.send_header("Content-type",
"text/xml")
Line 265: pureLen = len(response)
Unused
True, it's some left over from my logging
Line 266: if self.encode_threshold is not None:
Line 267: if pureLen > self.encode_threshold:
Line 268: q = self.accept_encodings().get("gzip", 0)
Line 269: if q:
--
To view, visit
http://gerrit.ovirt.org/25201
To unsubscribe, visit
http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Iebdaa04b17e2c1df1c1852ed536c5d6d8ec8d88b
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Vinzenz Feenstra <vfeenstr(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Itamar Heim <iheim(a)redhat.com>
Gerrit-Reviewer: Nir Soffer <nsoffer(a)redhat.com>
Gerrit-Reviewer: Saggi Mizrahi <smizrahi(a)redhat.com>
Gerrit-Reviewer: Vinzenz Feenstra <vfeenstr(a)redhat.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes