Dan Kenigsberg has posted comments on this change.
Change subject: Move uninstall preun section to vdsm-unregister
......................................................................
Patch Set 1: I would prefer that you didn't submit this
(2 inline comments)
Thanks for attending to the task of spec cleanup.
However, %preun should have content, most probably.
It should be several calls to vdsm-tool functions. EL6 should probably have different
content than Fedora, as is the case today.
Plain moving of code out of the spec gives us nothing, certainly if it forces Fedora and
RHEL to behave the same.
....................................................
File vdsm.spec.in
Line 372: %preun
nothing at all should be done when the rpm is removed? I doubt that.
....................................................
File vdsm/vdsm-unregister.in
Line 1: !/bin/bash
#!/bin/bash
please test your code.
--
To view, visit
http://gerrit.ovirt.org/4526
To unsubscribe, visit
http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I4e7b5dc969dfb51e6880b9bb209a363609f5e123
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Lei Li <lilei(a)linux.vnet.ibm.com>
Gerrit-Reviewer: Adam Litke <agl(a)us.ibm.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce(a)redhat.com>
Gerrit-Reviewer: Lei Li <lilei(a)linux.vnet.ibm.com>
Gerrit-Reviewer: Ryan Harper <ryanh(a)us.ibm.com>