Ayal Baron has posted comments on this change.
Change subject: BZ#773210 - Avoid infinity loop when delete volume failed during the
merge
......................................................................
Patch Set 1: (1 inline comment)
....................................................
File vdsm/storage/image.py
Line 925: try:
you should move this entire try..except clause to a separate (internal) function and run
it with retry. If it fails you should call:
chain.remove(srcVol.volUUID)
This would prevent endlessly looping in case of error and would take care of the sleep Dan
requested.
Alternatively, just move the 'srcVol = vol' line into finally
--
To view, visit
http://gerrit.ovirt.org/987
To unsubscribe, visit
http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I1368141fb240c9ca4e3fb3cfad04f88312cc46b5
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Igor Lvovsky <ilvovsky(a)redhat.com>
Gerrit-Reviewer: Ayal Baron <abaron(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Igor Lvovsky <ilvovsky(a)redhat.com>