Saggi Mizrahi has posted comments on this change.
Change subject: getStorageDomainInfo: SP keys when disconnected.
......................................................................
Patch Set 2: Code-Review+1
(1 comment)
....................................................
File vdsm/storage/hsm.py
Line 2738: # remove this when we can stop supporting this API.
Line 2739: if info['role'] != sd.MASTER_DOMAIN:
Line 2740: info.update({'lver': -1, 'spm_id': -1,
'master_ver': 0})
Line 2741: else:
Line 2742: pmd = sp.StoragePool._getPoolMD(dom)
Just add a comment since you are accessing a private method
Line 2743: info['lver'] = pmd[sp.PMDK_LVER]
Line 2744: info['master_ver'] = pmd[sp.PMDK_MASTER_VER]
Line 2745: info['spm_id'] = -1
Line 2746: try:
--
To view, visit
http://gerrit.ovirt.org/19555
To unsubscribe, visit
http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I8b7323d4ccaaaec0f39d5590a06879faa7fc999e
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Eduardo <ewarszaw(a)redhat.com>
Gerrit-Reviewer: Ayal Baron <abaron(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Elad Ben Aharon <eladba1990(a)gmail.com>
Gerrit-Reviewer: Gadi Ickowicz <gickowic(a)redhat.com>
Gerrit-Reviewer: Saggi Mizrahi <smizrahi(a)redhat.com>
Gerrit-Reviewer: Yeela Kaplan <ykaplan(a)redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes