Francesco Romani has posted comments on this change.
Change subject: virt: graphdev: add the GraphicsDevice class
......................................................................
Patch Set 22:
(2 comments)
http://gerrit.ovirt.org/#/c/26895/22/vdsm/virt/vm.py
File vdsm/virt/vm.py:
Line 1358: vmc.appendChildWithArgs('target', type='virtio',
Line 1359: name='com.redhat.spice.0')
Line 1360: return vmc
Line 1361:
Line 1362: def _getSpiceChannels(self):
actually, I would have preferred this to occur in a separate patch.
This p
You are right. If you want me to split it up (with no code changes) just tell
me and I'll do with zero problems.
Line 1363: for name in
self.specParams['spiceSecureChannels'].split(','):
Line 1364: if name in GraphicsDevice.SPICE_CHANNEL_NAMES:
Line 1365: yield name
Line 1366: elif (name[0] == 's' and name[1:] in
Line 2650: # we need to handle the case getStats is called before
'devices' is
Line 2651: # updated in Vm._run (buildConfDevices and the following code).
Line 2652: # easily reproduced with functional tests, but also possible
Line 2653: # in the wild
Line 2654: for dev in self.conf.get('devices', []) +
self.getConfGraphics():
Seeing that we've missed such a serious flaw previously, does not
make me f
I don't want to hide anything under the carpet, but this is IMHO less
serious than it looks.
In my tests, engine (3.5.0-master) do pass a 'devices' entry,
and the buildConfDevices had always run before a getStats() call, so the issue hasn't
shown up.
The functional tests does not pass a 'devices' entry for the Vm configuration, so
the old code
self.conf.get('devices', self.getConfGraphics())
Had the intended effect; however, that was incorrect and fixed only the very specific
functional test scenario.
The new testRunningVm passed an empty devices collection (but a dict instead a list, this
is a bug which deservers a different patch), and that triggered the bug this change
fixed.
I'll work to have stricter check for future verification.
Line 2655: if dev['type'] == GRAPHICS_DEVICES:
Line 2656: stats.update(getInfo(dev))
Line 2657: break
Line 2658:
--
To view, visit
http://gerrit.ovirt.org/26895
To unsubscribe, visit
http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I82e4414aa3efe7c756ba8ef9b7b47e591613a717
Gerrit-PatchSet: 22
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani <fromani(a)redhat.com>
Gerrit-Reviewer: Antoni Segura Puimedon <asegurap(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce(a)redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani(a)redhat.com>
Gerrit-Reviewer: Frank Kobzik <fkobzik(a)redhat.com>
Gerrit-Reviewer: Martin Polednik <mpoledni(a)redhat.com>
Gerrit-Reviewer: Michal Skrivanek <michal.skrivanek(a)redhat.com>
Gerrit-Reviewer: Vinzenz Feenstra <vfeenstr(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes