Nir Soffer has posted comments on this change.
Change subject: automation: Enable xunit report
......................................................................
Patch Set 4:
(1 comment)
https://gerrit.ovirt.org/#/c/46640/4/automation/build-artifacts.sh
File automation/build-artifacts.sh:
Line 15: make PYFLAKES=true PEP8=true NOSE_EXCLUDE=.* rpm
Line 16:
Line 17: find "$BUILDS" \
Line 18: -iname \*.rpm \
Line 19: -exec mv {} "$EXPORTED_ARTIFACTS/" \;
this will not work, as build-artifacts.sh will be run independently
too (th
How about:
. common.sh
And have the common vars there?
Having simple scripts that run without arguments or env vars is fine, but duplicating
configuration info is not.
Line 20: find "$PWD" \
Line 21: -maxdepth 1 \
Line 22: -iname vdsm\*.tar.gz \
--
To view, visit
https://gerrit.ovirt.org/46640
To unsubscribe, visit
https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie8c09cf21e7cf4a97b7b006f2b3ebe4943ed72b9
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer <nsoffer(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: David Caro <dcaroest(a)redhat.com>
Gerrit-Reviewer: Ido Barkan <ibarkan(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer <nsoffer(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-HasComments: Yes