Ayal Baron has posted comments on this change.
Change subject: Add deathSignal options to better peopen
......................................................................
Patch Set 9: Looks good to me, but someone else must approve
(4 inline comments)
....................................................
Commit Message
Line 7: Add deathSignal options to better peopen
s/peopen/popen/
....................................................
File vdsm/betterPopen/__init__.py
Line 37: # deathDignal is the signal that will be sent to the child process
s/Dignal/Signal
Line 39: # popen and when using standard peopen we should make sure we
s/peopen/popen/
Line 40: # reimplement this.
have you suggested this in upstream python?
--
To view, visit
http://gerrit.ovirt.org/6241
To unsubscribe, visit
http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I9f987129cea112e2a75d6f02477369417cc50dc7
Gerrit-PatchSet: 9
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Saggi Mizrahi <smizrahi(a)redhat.com>
Gerrit-Reviewer: Ayal Baron <abaron(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Ewoud Kohl van Wijngaarden <ewoud(a)kohlvanwijngaarden.nl>
Gerrit-Reviewer: Federico Simoncelli <fsimonce(a)redhat.com>
Gerrit-Reviewer: Saggi Mizrahi <smizrahi(a)redhat.com>
Gerrit-Reviewer: Shu Ming <shuming(a)linux.vnet.ibm.com>
Gerrit-Reviewer: Xu He Jie <xuhj(a)linux.vnet.ibm.com>
Gerrit-Reviewer: oVirt Jenkins CI Server