Dan Kenigsberg has posted comments on this change.
Change subject: One shot prepare.
......................................................................
Patch Set 12: Code-Review-1
(1 comment)
Eduardo, let's solve the constants.py issue, as well as the unit test failure. This
patch is too important to be held on such trivialities.
Traceback (most recent call last):
File "/home/jenkins/workspace/vdsm_unit_tests_gerrit/tests/volumeTests.py",
line 68, in test
self.volUUID)
File
"/home/jenkins/workspace/vdsm_unit_tests_gerrit/vdsm/storage/fileVolume.py",
line 409, in getVSize
volPath = os.path.join(sdobj.mountpoint, sdobj.sdUUID, 'images',
AttributeError: 'FileDomainMockObject' object has no attribute
'mountpoint'
....................................................
File vdsm/storage/blockSD.py
Line 1038: the chain.
Line 1039:
Line 1040: srcImgPath: Dir where the image volumes are.
Line 1041: """
Line 1042: sdRunDir = os.path.join("/var/run/vdsm/storage",
self.sdUUID)
It may not be the best idea to strengthen the dependency of the storage subsystem on vdsm
proper, but lacking any other idea, I suggest to put in lib/vdsm/constants.py.in
P_VDSM_STORAGE = P_VDSM_RUN + 'storage/'
and to use it both here and in fileSD.py.
Line 1043: imgRunDir = os.path.join(sdRunDir, imgUUID)
Line 1044: fileUtils.createdir(imgRunDir)
Line 1045: for volUUID in volUUIDs:
Line 1046: srcVol = os.path.join(srcImgPath, volUUID)
--
To view, visit
http://gerrit.ovirt.org/4220
To unsubscribe, visit
http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Id47db9c53199385dd5d08586e4782ea23885eb72
Gerrit-PatchSet: 12
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Eduardo <ewarszaw(a)redhat.com>
Gerrit-Reviewer: Ayal Baron <abaron(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Eduardo <ewarszaw(a)redhat.com>
Gerrit-Reviewer: Elad Ben Aharon <eladba1990(a)gmail.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce(a)redhat.com>
Gerrit-Reviewer: Greg Padgett <gpadgett(a)redhat.com>
Gerrit-Reviewer: Haim Ateya <hateya(a)redhat.com>
Gerrit-Reviewer: Igor Lvovsky <ilvovsky(a)redhat.com>
Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei(a)redhat.com>
Gerrit-Reviewer: Yeela Kaplan <ykaplan(a)redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes