Francesco Romani has posted comments on this change.
Change subject: call stop_event_loop upon exit
......................................................................
Patch Set 5: Verified+1
(1 comment)
VDSM still stops, the newly added function call seem to have negligible (near zero) impact
in shutdown time (tried ~10 times and estimated times using VDSM log timestamps). Hence,
V+1
https://gerrit.ovirt.org/#/c/26532/5/lib/vdsm/libvirtconnection.py
File lib/vdsm/libvirtconnection.py:
Line 72: __event_loop.start()
Line 73:
Line 74:
Line 75: def stop_event_loop(wait=True):
Line 76: __event_loop.stop(wait)
in a future patch i'd like to switch the defaults here
Line 77:
Line 78:
Line 79: __connections = {}
Line 80: __connectionLock = threading.Lock()
--
To view, visit
https://gerrit.ovirt.org/26532
To unsubscribe, visit
https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I9ab0d9b7be976e37a89a96d2f09a353186008731
Gerrit-PatchSet: 5
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce(a)redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer <nsoffer(a)redhat.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-HasComments: Yes