Igor Lvovsky has posted comments on this change.
Change subject: Refactor storage connection subsystem
......................................................................
Patch Set 4: (8 inline comments)
Not finished yet. It's too big and complicated
....................................................
File vdsm.spec.in
Line 477: %{_datadir}/%{vdsm_name}/storage/storageProividerConnectionMonitor.py*
Did we agreed about sorting?
....................................................
File vdsm/storage/hsm.py
Line 127: # ISCSI domain shouldn't even be on the list but VDSM use to just
Do you mean FCP?
Line 1871: status = 200
Use se.StorageException.code
Line 1897: corosponding domains type
corresponding
Line 1900: with keys depnding ont the type
ont???
Line 1904: :returns: a list of statuses status will be 0 if disconnection was
successful
Ah, you fixed docstring here. I wrote in you previous patch dedicated to docstring that
you should change this one too. Consider to merge this two patches
Line 1927: status = 200
Use se.StorageException.code
....................................................
File vdsm/storage/Makefile.am
Line 28: storageProviderConnectionMonitor.py \
Did we agreed about sorting?
--
To view, visit
http://gerrit.ovirt.org/1038
To unsubscribe, visit
http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ifc5c160aba9b4cc88225dde0c44f9b766c6a4c0d
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Saggi Mizrahi <smizrahi(a)redhat.com>
Gerrit-Reviewer: Ayal Baron <abaron(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce(a)redhat.com>
Gerrit-Reviewer: Igor Lvovsky <ilvovsky(a)redhat.com>
Gerrit-Reviewer: Saggi Mizrahi <smizrahi(a)redhat.com>