Francesco Romani has posted comments on this change.
Change subject: misc: Safer and simpler itmap
......................................................................
Patch Set 6:
(2 comments)
nice improvement
https://gerrit.ovirt.org/#/c/39119/6/vdsm/storage/misc.py
File vdsm/storage/misc.py:
Line 904: return
Line 905: try:
Line 906: results.put(func(value))
Line 907: except Exception as e:
Line 908: results.put(e)
nice!
Line 909:
Line 910: for value in iterable:
Line 911: values.put(value)
Line 912:
Line 922: a
maybe you forgot an 'xrange' here (should be 'range')
--
To view, visit
https://gerrit.ovirt.org/39119
To unsubscribe, visit
https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Iba6116ac4003702c8e921cebaf494491a6f9afaf
Gerrit-PatchSet: 6
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer <nsoffer(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce(a)redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani(a)redhat.com>
Gerrit-Reviewer: Nir Soffer <nsoffer(a)redhat.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes