Zhou Zheng Sheng has posted comments on this change.
Change subject: Title: fix some code style consist with pep8
......................................................................
Patch Set 2: (13 inline comments)
Great work! When look at the file again, I find some small comment placement problems.
....................................................
File vdsm/storage/storage_exception.py
Line 68: #################################################
I think this block of comment indicate a code section. It tries to say "the two
Exception class below are for Validation Exceptions". So the comment is like a
section start tag. I suggest you apply the following style:
# aaaaaaaaa
# aaaaaaaaa
class Except1(Exception):
pass
class Except2(Exception):
pass
# aaaaaaaaa
# aaaaaaaaa
class Except3(Exception):
pass
class Except4(Exception):
pass
Line 85: #################################################
Same as line 68.
Line 125: #################################################
Same as line 68.
Line 178: #################################################
Same as line 68.
Line 336: #################################################
Same as line 68.
Line 449: #################################################
Same as line 68.
Line 616: #################################################
Same as line 68.
Line 900: #################################################
Same as line 68.
Line 1015: #################################################
Same as line 68.
Line 1188: #################################################
Same as line 68.
Line 1516: #################################################
Same as line 68.
Line 1603: #################################################
Same as line 68.
Line 1675: #################################################
This block of comment is nicer compared to line 68.
--
To view, visit
http://gerrit.ovirt.org/4500
To unsubscribe, visit
http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I50cf61d9b7815cbdd5571930e3f9be59183a83f4
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Changming Bai <baichm(a)linux.vnet.ibm.com>
Gerrit-Reviewer: Changming Bai <baichm(a)linux.vnet.ibm.com>
Gerrit-Reviewer: Zhou Zheng Sheng <zhshzhou(a)linux.vnet.ibm.com>